Remove unnecessary with-context-classloader in compile.clj #73
+109
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arohner
force-pushed
the
speed
branch
3 times, most recently
from
3f1e5cc to
1581596
Compare
english
approved these changes
Nov 16, 2025
arohner
force-pushed
the
speed
branch
18 times, most recently
from
cf12fe4 to
13af45b
Compare
miridius
approved these changes
Nov 26, 2025
src/rules_clojure/compile.clj
Outdated
Comment on lines
266
to
267
| (fn | ||
| ([] |
There was a problem hiding this comment.
nit: unnecessary paren
Suggested change
| (fn | |
| ([] | |
| (fn [] |
| (mapv (fn [[d *f]] | ||
| (when (= :timeout (deref *f 30000 :timeout)) | ||
| (throw (ex-info (print-str "timeout in" ns "waiting for" d) {:dep d})))))) | ||
| (mapv deref)) |
src/rules_clojure/compile.clj
Outdated
Comment on lines
542
to
543
|
|
||
| (comment "text here to force rebuilding - 2") |
Open
arohner
added a commit
that referenced
this pull request
Dec 2, 2025
- When determining whether two classloaders are compatible?, also check for java class names, not just clj namespaces. This identifies JarHell as a major source of compile errors and non-determinism - gen_build: Make clojure_library targets depend on clojure.core.specs.alpha rather than clojure.core. This fixes a bug where clojure.core.specs.alpha gets compiled into user jars, causing false positives in compatibility checks. - minor comments and code golfing
arohner
added a commit
that referenced
this pull request
Dec 2, 2025
- When determining whether two classloaders are compatible?, also check for java class names, not just clj namespaces. This identifies JarHell as a major source of compile errors and non-determinism - gen_build: Make clojure_library targets depend on clojure.core.specs.alpha rather than clojure.core. This fixes a bug where clojure.core.specs.alpha gets compiled into user jars, causing false positives in compatibility checks. - minor comments and code golfing
arohner
added a commit
that referenced
this pull request
Dec 3, 2025
- When determining whether two classloaders are compatible?, also check for java class names, not just clj namespaces. This identifies JarHell as a major source of compile errors and non-determinism - gen_build: Make clojure_library targets depend on clojure.core.specs.alpha rather than clojure.core. This fixes a bug where clojure.core.specs.alpha gets compiled into user jars, causing false positives in compatibility checks. - minor comments and code golfing
arohner
added a commit
that referenced
this pull request
Dec 3, 2025
- When determining whether two classloaders are compatible?, also check for java class names, not just clj namespaces. This identifies JarHell as a major source of compile errors and non-determinism - gen_build: Make clojure_library targets depend on clojure.core.specs.alpha rather than clojure.core. This fixes a bug where clojure.core.specs.alpha gets compiled into user jars, causing false positives in compatibility checks. - minor comments and code golfing
arohner
added a commit
that referenced
this pull request
Dec 3, 2025
- When determining whether two classloaders are compatible?, also check for java class names, not just clj namespaces. This identifies JarHell as a major source of compile errors and non-determinism - gen_build: Make clojure_library targets depend on clojure.core.specs.alpha rather than clojure.core. This fixes a bug where clojure.core.specs.alpha gets compiled into user jars, causing false positives in compatibility checks. - minor comments and code golfing
arohner
added a commit
that referenced
this pull request
Dec 3, 2025
- When determining whether two classloaders are compatible?, also check for java class names, not just clj namespaces. This identifies JarHell as a major source of compile errors and non-determinism - gen_build: Make clojure_library targets depend on clojure.core.specs.alpha rather than clojure.core. This fixes a bug where clojure.core.specs.alpha gets compiled into user jars, causing false positives in compatibility checks. - minor comments and code golfing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes following from #70 . We don't need to
with-context-classloaderinside compile.clj, because the call in jar.clj is sufficient.