-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the uhf value when xtb calculates with lanthanides #60
Merged
jonathan-schoeps
merged 9 commits into
grimme-lab:main
from
jonathan-schoeps:bug/f_in_core_approx
Oct 10, 2024
Merged
Changed the uhf value when xtb calculates with lanthanides #60
jonathan-schoeps
merged 9 commits into
grimme-lab:main
from
jonathan-schoeps:bug/f_in_core_approx
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
jonathan-schoeps
requested review from
marcelmbn and
thfroitzheim
as code owners
October 9, 2024 11:32
marcelmbn
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked these two aspects:
- The number of unpaired electrons with which
xtb
is started. You could also have a look at the command-line call - Is the
UHF
value actually set back to the original value afterwards?
|
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
marcelmbn
reviewed
Oct 9, 2024
…plemented Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
…ndlessGen into bug/f_in_core_approx
Now all the requested changes should be implemented. |
marcelmbn
reviewed
Oct 9, 2024
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
marcelmbn
reviewed
Oct 9, 2024
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
marcelmbn
reviewed
Oct 9, 2024
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
marcelmbn
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
marcelmbn
added a commit
that referenced
this pull request
Oct 10, 2024
* Initial commit contract coordinates Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * new function to contract the coordinates before the xtb scf Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * The coordinates are now drawn towards the origin to improve convergence. Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * The coordinates are now drawn towards the origin to improve convergence. Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * suggest changes to dev/contract_coordinates to make code more consistent and clean Signed-off-by: Marcel Müller <marcel.mueller@thch.uni-bonn.de> * merged dev/dist_cov_radii and the changes to the function contract_coords Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * bug fix were the boolean was not correctly passed on Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * add IP/EA check with g-xTB for special purpose dev application only Signed-off-by: Marcel Müller <marcel.mueller@thch.uni-bonn.de> * rename gp3 to gxtb consistently Signed-off-by: Marcel Müller <marcel.mueller@thch.uni-bonn.de> * Changes which were done twice are removed Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * Changed a thing left over from teh debugging Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * Changed a Todo Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * suggested changes within the PR Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * Update mindlessgen.toml Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * Update src/mindlessgen/prog/config.py Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * mindlessgen.toml now consistent with the default Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * Update on ReadMe.md and clearification with the different scaling factors Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * Update CHANGELOG.md Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * Update CHANGELOG.md Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * Update mindlessgen.toml Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * Update README.md Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * Update README.md Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * Update mindlessgen.toml Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * A sentence is now bolt Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * Changed the uhf value when xtb calculates with lanthanides (#60) * Changed the uhf assingement when xtb calculates with lanthanides Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * The f electrons are now calculated and substractet correctly Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * Update CHANGELOG.md Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> * The f electron removal for lanthanides are now for the singlepoint implemented Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * check_ligand_uhf is now a function Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * The ValueError is now inside the check_ligand_uhf function Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> * check_ligand_uhf now returns nothing but raises a ValueError Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> --------- Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de> --------- Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de> Signed-off-by: Marcel Müller <marcel.mueller@thch.uni-bonn.de> Co-authored-by: Jonathan Schöps <s6jtscho@uni-bonn.de> Co-authored-by: Joanthan Schöps <106986430+jonathan-schoeps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xtb calculation when lanthanides are present in the molecule now calculates with uhf = 0 to avoid shifting the uhf assignment to the ligands. When the xtb run is finished, the original uhf is reassigned to the molecule. This is linked to #50