Skip to content

Update with pushes to main #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Oct 10, 2024
Merged

Conversation

marcelmbn
Copy link
Member

No description provided.

jonathan-schoeps and others added 30 commits September 13, 2024 11:30
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
…ent and clean

Signed-off-by: Marcel Müller <marcel.mueller@thch.uni-bonn.de>
…oordinates

Suggest changes to `dev/contract_coordinates` to make code more consist…
…ords

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Signed-off-by: Marcel Müller <marcel.mueller@thch.uni-bonn.de>
Signed-off-by: Marcel Müller <marcel.mueller@thch.uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
…oordinates

A new function to contract the coordinates after the random generation to ensure that the atoms are not to far apart.
…tors

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
jonathan-schoeps and others added 5 commits October 8, 2024 13:41
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
An update in the ReadMe.md to be more specific with the element composition function.
…b#60)

* Changed the uhf assingement when xtb calculates with lanthanides

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>

* The f electrons are now calculated and substractet correctly

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>

* Update CHANGELOG.md

Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>

* The f electron removal for lanthanides are now for the singlepoint implemented

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>

* check_ligand_uhf is now a function

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>

* The ValueError is now inside the check_ligand_uhf function

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>

* check_ligand_uhf now returns nothing but raises a ValueError

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>

---------

Signed-off-by: Jonathan Schöps <s6jtscho@uni-bonn.de>
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
@marcelmbn marcelmbn merged commit 3095315 into grimme-lab:dev/gp3_ipea Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants