prepare for adding prebuild binaries to releases #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prebuilt: remove Node v10.x
ci: remove permissions UAC
Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Relate-to: TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <rzr@users.sf.net>
- This updates the README to be inline with what's in master
* Ensure JavaScript exceptions bubble up * Fix segfault * Fix mutex segfault * Fix segfault caused by memory leak If the database was being closed, and non-exclusive work was scheduled, it overrode the lock flag such that the state became open=false locked=false instead of open=false locked=true. This caused queued work to not be processed, leaking memory, which causes a segfault during napi cleanup. Make the same changes to other methods for safe measure.
* release: 5.0.1 * release: update log
…d52bdb2d0d6e5b2edd9aee sqlite-autoconf-3340000.tar.gz)
Executing "npm install --build-from-source" only builds the module for one of the N-API target versions. The build command has to be executed explicitly to generate builds targeting each of the specified N-API versions. This should fix publishing binaries.
* bug: verify toString() returns valid data * test: faulty toString test
- we shouldn't be tracking this for a library, but it's annoying when you're developing locally
closes TryGhost#419 - this adds support for a `change` event which forwards events arising from `sqlite3_update_hook`
- added constant exports and missing functions to Database
- this adds support for supplying Darwin ARM64 prebuilt binaries for node-sqlite3
refs https://www.sqlite.org/releaselog/3_39_4.html - sha3-256sum: `431328e30d12c551da9ba7ef2122b269076058512014afa799caaf62ca567090`
refs https://www.sqlite.org/releaselog/3_40_0.html - sha3-256sum: `7ee8f02b21edb4489df5082b5cf5b7ef47bcebcdb0e209bf14240db69633c878`
- done for DRY purposes when reading the code
- the default repo branch has been renamed to `main`
fixes TryGhost#1663 - Ubuntu 22.04 ships with a newer glibc so the prebuilt binaries end up being linked to a more recent version, removing compatibility with systems that ship with older variants - this commit fixes that by downgrading the Ubuntu version
This reverts commit af8e567.
Member
Author
|
There is a trial run here: https://github.com/gristlabs/node-sqlite3/actions/runs/4016600020
|
Member
Author
|
Output can now be tested as follows: The If it starts building, then prebuilt versions didn't work out :( Then try running runs and prints out |
Member
|
Works on a Mac! and |
Member
Author
|
Thanks for confirming @dsagal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
binarysection of package.json at our repo, so that binaries placed in github releases here get used automatically.This is a cleaned up version of my own fork of node-sqlite3. The bulk is a fairly uneventful merge, with changes in b9d8102