Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BUILD_ONLY mode inside Docker #173

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Fix BUILD_ONLY mode inside Docker #173

merged 2 commits into from
Nov 23, 2024

Conversation

zeha
Copy link
Member

@zeha zeha commented Nov 22, 2024

updatebase.GRMLBASE mounts various special filesystems. This fails in Docker, where mounting filesystems (even existing ones) does not work.

Half of the mounts were already guarded with || true. Guard the others too, so they can be skipped.

@zeha zeha requested a review from mika November 22, 2024 21:21
@zeha zeha self-assigned this Nov 22, 2024
@zeha zeha mentioned this pull request Nov 22, 2024
@zeha zeha merged commit 6b8da86 into master Nov 23, 2024
6 checks passed
@zeha zeha deleted the build_only-docker branch November 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants