Import CI build drivers #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mika
reviewed
Nov 23, 2024
grml-live
Outdated
| local rc=0 | ||
| mount -o loop "${EXTRACT_ISO_NAME}" "$mountpoint" ; rc=$? | ||
| mkdir -p "${tempdir}/live/" | ||
| osirrox -indev "${EXTRACT_ISO_NAME}" -extract live "${tempdir}/live/" |
There was a problem hiding this comment.
missing the "; rc=$?" at the end to propagate the exit code for lines below?
grml-live
Outdated
| rmdir "$mountpoint" | ||
| log "mount failed" | ||
| eerror "mount failed" | ||
| rm -r "$tempdir" |
There was a problem hiding this comment.
are we good/fine with rm -r (as in: no need for rm -rf)?
There was a problem hiding this comment.
Was pondering that; have now added -f.
mount -o loop is disabled in our new build environment, so avoid that and use xorriso (actually, osirrox) to extract the squashfs file from the ISO.
mika
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are our new build scripts for driving grml-live from CI. Not the nicest Python I've ever written, but it works.
This PR also contains #172 and #173 for now, as I needed them for testing in the same branch.