Add Heroku button #2
Conversation
| @@ -1,7 +1,5 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| ruby File.read('.ruby-version').strip if ENV["RACK_ENV"] == "production" # strict ruby version only on heroku | |||
There was a problem hiding this comment.
I want a stable / know ruby version ...
| @@ -1,5 +1,7 @@ | |||
| Unify reports from all your tests runs and send them as one. | |||
|
|
|||
| Run your own hosted batching [](https://heroku.com/deploy) | |||
There was a problem hiding this comment.
prefix with Alternatively: ... since it's not required
| "CUSTOM_RUBY_VERSION": "2.2.4", | ||
| "CODECLIMATE_REPO_TOKEN": "XXXXXX", | ||
| "ROLLBAR": "Rollbar key", | ||
| "TO_FILE": "1" |
There was a problem hiding this comment.
there is a CODECLIMATE_TO_FILE option from codeclimate/ruby-test-reporter#84
| "memcachier:dev" | ||
| ], | ||
| "env": { | ||
| "CUSTOM_RUBY_VERSION": "2.2.4", |
There was a problem hiding this comment.
don't need that ... reuse .ruby-version
|
thx, nice to have a button :) |
| @@ -1,5 +1,7 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| ruby File.read('.ruby-version').strip if ENV["RACK_ENV"] == "production" # strict ruby version only on heroku | |||
There was a problem hiding this comment.
why not locally ?
... I'd rather not run a different version when developing ...
There was a problem hiding this comment.
That was the way that you had it originally 😉
I'd definitely down to put the ruby version in the Gemfile and remove the .ruby-version though .
There was a problem hiding this comment.
past me was an idiot ... should not look at his code ;)
There was a problem hiding this comment.
.ruby-version is nice because it makes rbenv / travis / heroku etc pick the right version
No description provided.