Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heroku button #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Heroku button #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35fc2ce
remove strict version from gemfile
sethherr Nov 9, 2016
bfae1d4
add heroku button, relax gemfile
sethherr Nov 10, 2016
91324b2
fix review issues
sethherr Nov 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.2.4
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
source "https://rubygems.org"

ruby File.read('.ruby-version').strip if ENV["RACK_ENV"] == "production" # strict ruby version only on heroku
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not locally ?
... I'd rather not run a different version when developing ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the way that you had it originally 😉

I'd definitely down to put the ruby version in the Gemfile and remove the .ruby-version though .

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

past me was an idiot ... should not look at his code ;)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.ruby-version is nice because it makes rbenv / travis / heroku etc pick the right version


group :test do
gem "rake"
end
Expand Down
4 changes: 2 additions & 2 deletions Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
Unify reports from all your tests runs and send them as one.

Run your own hosted batching [![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://heroku.com/deploy)

## Automated setup

Use [codeclimate batch](https://github.com/grosser/codeclimate_batch)

## Manual usage

Alternatively to using the hosted version from codeclimate_batch, you can host it yourself [![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://heroku.com/deploy)

```Ruby
# only do when running on master branch ... see codeclimate_batch for details
ENV["TO_FILE"] = "1"
Expand Down
4 changes: 1 addition & 3 deletions app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
"memcachier:dev"
],
"env": {
"CUSTOM_RUBY_VERSION": "2.2.4",
"CODECLIMATE_REPO_TOKEN": "XXXXXX",
"ROLLBAR": "Rollbar key",
"TO_FILE": "1"
"ROLLBAR": "Rollbar key"
}
}