-
Notifications
You must be signed in to change notification settings - Fork 164
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
bf3a96e
to
9c700e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 71.17% 71.71% +0.54%
==========================================
Files 8 8
Lines 333 350 +17
==========================================
+ Hits 237 251 +14
- Misses 85 87 +2
- Partials 11 12 +1
Continue to review full report at Codecov.
|
b9c6ded
to
f09a023
Compare
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
f09a023
to
d8343f8
Compare
@brancz PTAL if this is something you had in your mind? |
Nice! lgtm 👍 |
Thanks! |
resolves #83
Hi, I discovered that when using error wrapping, the reported
grpc_status
is reported as anUnknown
status. I encountered this issue in the Thanos project where for examplecontext canceled
error is normally reported asCancelled
gRPC status but once wrapped becomesUnknown
.The issue should be eventually solved in the go-grpc status package. There is even an issue for this grpc/grpc-go#2934. The problem is there are currently cca 3 ways to wrap errors and every one doing it different way.
I created a draft with bit hacky unwrapping of two of those, native Go unwrapping (commented out since added in 1.13.0 and I'm not sure how to deal with the dependency) and
pkg/errors
wrapf
.Not sure what is the right way to handle this, but currently this is quite inconvenient.
I'd be glad for any opinions on this.
Thanks!