feat: bump version of go-grpc-prometheus@v1.2.1-0.20191002090509-6af2… #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0e3a5340 Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
…0e3a5340 (#1602) Signed-off-by: Martin Chodur <m.chodur@seznam.cz> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…0e3a5340
Changes
Bumped version of go-grpc-prometheus interceptor for exposing metrics from grpc server.
I added error unwrapping to it since we ran into miss-categorized errors in metrics labels caused by wrapped errors using
errors.Wrapwhich the interceptor did not recognize as a grpc status.More info here:
The newer version should also provide metrics for streaming if I'm not mistaken looking at the commits.
Verification
Tests are still passing 🤞