Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: update proper benchmark binary to use larger buffers #6537

Merged
merged 1 commit into from
Aug 14, 2023
Merged

benchmark: update proper benchmark binary to use larger buffers #6537

merged 1 commit into from
Aug 14, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 10, 2023

#6516 updated the wrong binary, and had no effect on our results. This package appears to be what is actually run in our published benchmarks (ref).

RELEASE NOTES: none

@dfawley dfawley added the Type: Meta Github repo, process, etc label Aug 10, 2023
@dfawley dfawley added this to the 1.58 Release milestone Aug 10, 2023
@dfawley dfawley requested a review from easwars August 10, 2023 22:58
@easwars easwars assigned dfawley and unassigned easwars Aug 14, 2023
@dfawley dfawley closed this Aug 14, 2023
@dfawley dfawley reopened this Aug 14, 2023
@dfawley dfawley merged commit 53d1f23 into grpc:master Aug 14, 2023
1 check passed
@dfawley dfawley deleted the bmtake2 branch August 14, 2023 16:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

Assignees

@dfawley dfawley

Labels
Type: Meta Github repo, process, etc
Projects
None yet
Milestone
1.58 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @easwars