Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: update proper benchmark binary to use larger buffers #6537

Merged
merged 1 commit into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion benchmark/worker/benchmark_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ func setupClientEnv(config *testpb.ClientConfig) {
// It returns the connections and corresponding function to close them.
// It returns non-nil error if there is anything wrong.
func createConns(config *testpb.ClientConfig) ([]*grpc.ClientConn, func(), error) {
var opts []grpc.DialOption
opts := []grpc.DialOption{
grpc.WithWriteBufferSize(128 * 1024),
grpc.WithReadBufferSize(128 * 1024),
}

// Sanity check for client type.
switch config.ClientType {
Expand Down
5 changes: 4 additions & 1 deletion benchmark/worker/benchmark_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ func startBenchmarkServer(config *testpb.ServerConfig, serverPort int) (*benchma
}
runtime.GOMAXPROCS(numOfCores)

var opts []grpc.ServerOption
opts := []grpc.ServerOption{
grpc.WriteBufferSize(128 * 1024),
grpc.ReadBufferSize(128 * 1024),
}

// Sanity check for server type.
switch config.ServerType {
Expand Down