Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated code changes #7242

Closed
wants to merge 2 commits into from
Closed

fix: deprecated code changes #7242

wants to merge 2 commits into from

Conversation

yosuzzy
Copy link

@yosuzzy yosuzzy commented May 18, 2024

"Dial" method is deprecated.

So use "NewClient" instead. Will be better for newbee

@purnesh42H purnesh42H self-assigned this May 20, 2024
@purnesh42H purnesh42H added the Type: Documentation Documentation or examples label May 20, 2024
@purnesh42H
Copy link
Contributor

Thanks for the PR. Would you be able to change all the occurrences of it in documentation and examples?

@yosuzzy
Copy link
Author

yosuzzy commented May 21, 2024

Sure :)
I modified tutorial and sent PR on your docs page "grpc.io" PR
Please let me know if there are any more places I need to edit.

@purnesh42H
Copy link
Contributor

@yosuzzy you probably should first try searching for grpc.Dial( in /examples and /documentation and replace to equivalent NewClient calls

@dfawley
Copy link
Member

dfawley commented May 21, 2024

I think I got these and more in #7248

@dfawley dfawley closed this May 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants