Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: update remaining uses of grpc.Dial to NewClient #7248

Merged
merged 4 commits into from
May 21, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented May 21, 2024

RELEASE NOTES: none

@dfawley dfawley added the Type: Documentation Documentation or examples label May 21, 2024
@dfawley dfawley added this to the 1.65 Release milestone May 21, 2024
@dfawley dfawley requested a review from zasweq May 21, 2024 18:26
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (adf976b) to head (3fddd54).
Report is 56 commits behind head on master.

Current head 3fddd54 differs from pull request most recent head c2b8d81

Please upload reports for the commit c2b8d81 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7248      +/-   ##
==========================================
- Coverage   81.24%   80.55%   -0.69%     
==========================================
  Files         345      349       +4     
  Lines       33941    34027      +86     
==========================================
- Hits        27574    27410     -164     
- Misses       5202     5428     +226     
- Partials     1165     1189      +24     

see 35 files with indirect coverage changes

@zasweq zasweq assigned dfawley and unassigned zasweq May 21, 2024
@dfawley dfawley merged commit 2f52f9e into grpc:master May 21, 2024
12 checks passed
@dfawley dfawley deleted the exnc branch May 21, 2024 21:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants