Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient: e2e style tests for ads stream restart (5/N) #7696

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 2, 2024

#a71-xds-fallback
#xdsclient-refactor

Addresses #6902

RELEASE NOTES: none

@easwars easwars requested review from zasweq and purnesh42H October 2, 2024 18:09
@easwars easwars added this to the 1.68 Release milestone Oct 2, 2024
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but overall LGTM.

@zasweq zasweq assigned easwars and unassigned zasweq Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (ca4865d) to head (ff256e8).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7696      +/-   ##
==========================================
- Coverage   81.93%   81.83%   -0.11%     
==========================================
  Files         361      361              
  Lines       27822    27822              
==========================================
- Hits        22797    22768      -29     
- Misses       3838     3857      +19     
- Partials     1187     1197      +10     

see 21 files with indirect coverage changes

@easwars easwars merged commit 6c6c9b6 into grpc:master Oct 7, 2024
14 checks passed
@easwars easwars deleted the more_ads_tests branch October 7, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants