Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: address merge conflict gotcha and missed review comment from previous PRs #7705

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 7, 2024

RELEASE NOTES: none

@easwars easwars requested a review from zasweq October 7, 2024 23:50
@easwars easwars added this to the 1.68 Release milestone Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (5e6f4b9) to head (bf28777).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7705      +/-   ##
==========================================
- Coverage   81.88%   81.81%   -0.07%     
==========================================
  Files         361      361              
  Lines       27827    27827              
==========================================
- Hits        22786    22767      -19     
- Misses       3849     3859      +10     
- Partials     1192     1201       +9     

see 25 files with indirect coverage changes

@arvindbr8
Copy link
Member

Seems like build broke from this commit: #7696

Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but still concerned by our CI did not catch this merge conflict gotcha before merge.

Merging to get green builds

@arvindbr8 arvindbr8 merged commit bdd444d into grpc:master Oct 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants