xds: return all ServerConfig dial options together #7715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshitachandwani
added
the
Area: xDS
eshitachandwani
added
Type: Bug
and removed
Area: xDS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #7661
DialOptions()method that returns a slice of all dial options for the typeServerConfiginstead of individual methods to get all dial options.TestNewWithDialerFromCredentialsBundletest since it was already being tested here inTestClientCustomDialerFromCredentialsBundle(https://github.com/grpc/grpc-go/blob/b8ee37db62bef105fdbce649f0ee4ee8e78b1e46/test/xds/xds_client_custom_dialer_test.go#L83C10-L83C53)RELEASE NOTES: None