Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: return all ServerConfig dial options together #7715

Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update bootstrap.go
eshitachandwani authored Oct 9, 2024
commit 97faa203a89e89e9d97c248db7aa1ad50248e157
2 changes: 1 addition & 1 deletion internal/xds/bootstrap/bootstrap.go
Original file line number Diff line number Diff line change
@@ -220,7 +220,7 @@ func (sc *ServerConfig) ServerFeaturesIgnoreResourceDeletion() bool {
return false
}

// DialOptions returns a slice of all the configured dial options for this
// DialOptions returns a slice of all the configured dial options for the
// server.
func (sc *ServerConfig) DialOptions() []grpc.DialOption {
dopts := []grpc.DialOption{sc.credsDialOption}