Skip to content

xds: fix parsing RouteLookupClusterSpecifier mistake #8641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2021
Merged

xds: fix parsing RouteLookupClusterSpecifier mistake #8641

merged 1 commit into from
Nov 10, 2021

Conversation

@dapengzhang0
Copy link
Contributor

@dapengzhang0 dapengzhang0 commented Nov 1, 2021

  • Partially revert the change of RlsProtoData.java in xds: add RlsClusterSpecifierPlugin for RLS-in-xDS #8612 by removing public accessor
  • Have grpc-xds no longer strongly depend on grpc-rls. The application will need grpc-rls as runtime dependencies if they need route lookup feature in xds.
  • Parse RouteLookupServiceClusterSpecifierPlugin config to the Json/Map representation of io.grpc.lookup.v1.RouteLookupClusterSpecifier instead of io.grpc.rls.RlsProtoData.RouteLookupConfig

@dapengzhang0 dapengzhang0 requested a review from sergiitk November 1, 2021 16:33
@dapengzhang0
Copy link
Contributor Author

dapengzhang0 commented Nov 8, 2021

@sergiitk friendly ping

@dapengzhang0
Copy link
Contributor Author

dapengzhang0 commented Nov 10, 2021

Thank you @sergiitk for the review.

@dapengzhang0 dapengzhang0 merged commit ad0971e into grpc:master Nov 10, 2021
@dapengzhang0 dapengzhang0 deleted the fix-rls-parsing branch November 10, 2021 19:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sergiitk sergiitk sergiitk approved these changes

Assignees

No one assigned

Labels

Type: Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dapengzhang0 @sergiitk