-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: migrate udpa proto to xds directory #8686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is still a work in progress. It's not clear to me what you were wanting me to look at.
yea i was thinking of splitting the fix into two so i asked you to review, because my protoc generator is in another environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a future change going to rename xds/third_party/udpa to xds/third_party/xds?
We need to make changes upstream to add java_package options. We don't have to block this PR on it, but it does need to happen. It seems we've gotten sloppy and haven't been doing that for many protos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still wondering when we'll rename xds/third_party/udpa to xds/third_party/xds.
it looks only little changes needed in order to rename the directory. so let's include it here. |
fix #8631:
https://github.com/cncf/xds.git
instead ofhttps://github.com/cncf/udpa.git
https://github.com/cncf/xds.git
, details was here Stable release of Go generated protos cncf/xds#2 (comment)