Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use capital F for Function when used as a type #307

Merged
merged 1 commit into from
May 3, 2018

Conversation

JustinBeckwith
Copy link
Contributor

This was causing compilation errors with Node.js 10 in nodejs-common-grpc.

cc @alexander-fenster

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@JustinBeckwith
Copy link
Contributor Author

I signed it!

@JustinBeckwith
Copy link
Contributor Author

Rad. I don't have merge rights on this repo, so one of y'all need to :)

@nicolasnoble nicolasnoble merged commit bee673f into grpc:v1.11.x May 3, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants