Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop /release #542

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Drop /release #542

merged 1 commit into from
Nov 24, 2020

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Nov 23, 2020

Closes #502

Note that I haven't included a redirect rule, since IMHO, it is probably best that any old script that made use of https://grpc.io/release should fail with a 404, rather than be redirected and eventually result in a 200 status. If someone really feels strongly about adding a redirect rule, then maybe https://github.com/grpc/grpc/releases might make sense.

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jtattermusch
Copy link
Contributor

I updated the internal go/grpc-release doc (removed the step to update grpc.io/release).

@chalin chalin merged commit dfe7d84 into main Nov 24, 2020
@chalin chalin deleted the chalin-drop-release-url-2020-11-23 branch November 24, 2020 13:14
@chalin
Copy link
Collaborator Author

chalin commented Jan 24, 2021

I've also dropped /release from the old GitHub-pages hosted site, for details see grpc/grpc.github.io#871.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop the site's release file
2 participants