-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the site's release file #502
Comments
@jtattermusch can answer best. For reference: grpc/grpc#21891 |
Very interesting background reading! Thanks @ejona86. Since #79 eliminated uses of (For reference, #80 is the PR that introduced the |
I think the grpc.io release file might not be used anymore, but TBH I'm not sure and there's a bunch or internal docs (especially the release process docs) one would need to review/update first. What would we gain by dropping the release file? If there's some significant gain from that, we can take the time and double check that the file is now really unnecessary. Otherwise I'm not sure it's worth doing the work. |
Thanks for the feedback @jtattermusch. Regarding gains: as part of the migration to docsy there'll be some cleanup done. If this release URL isn't being used, then it's like dead code -- it adds cruft w/o value. There's enough complexity in this site w/o having to keep unused features. Ok, let's put this on hold for now. I'll revisit later after the docsy migration. |
I've investigated the use of the grpc.io/release file and it seems that we can get rid of it. The only use I've found is in the go/grpc-release doc (internal only) and I can remove those references once a PR exists to remove the logic for generating the grpc.io/release content. |
Done, see #542 |
https://grpc.io/release yields the grpc/grpc release with which the site was configured.
grpc/grpc
as opposed to, say, Java or Go?The text was updated successfully, but these errors were encountered: