Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the site's release file #502

Closed
chalin opened this issue Nov 5, 2020 · 6 comments · Fixed by #542
Closed

Drop the site's release file #502

chalin opened this issue Nov 5, 2020 · 6 comments · Fixed by #542
Assignees
Labels
e0-minutes Effort: < 60 min p2-medium

Comments

@chalin
Copy link
Collaborator

chalin commented Nov 5, 2020

https://grpc.io/release yields the grpc/grpc release with which the site was configured.

  • Is this site feature used anywhere?
  • Why single out grpc/grpc as opposed to, say, Java or Go?
@chalin chalin added the question Further information is requested label Nov 5, 2020
@ejona86
Copy link
Member

ejona86 commented Nov 5, 2020

@jtattermusch can answer best. For reference: grpc/grpc#21891

@chalin
Copy link
Collaborator Author

chalin commented Nov 6, 2020

Very interesting background reading! Thanks @ejona86.

Since #79 eliminated uses of $(curl -L https://grpc.io/release), can we now eliminate https://grpc.io/release, or is it used elsewhere?

(For reference, #80 is the PR that introduced the release to grpc.io.)

@jtattermusch
Copy link
Contributor

I think the grpc.io release file might not be used anymore, but TBH I'm not sure and there's a bunch or internal docs (especially the release process docs) one would need to review/update first.

What would we gain by dropping the release file? If there's some significant gain from that, we can take the time and double check that the file is now really unnecessary. Otherwise I'm not sure it's worth doing the work.

@chalin
Copy link
Collaborator Author

chalin commented Nov 18, 2020

Thanks for the feedback @jtattermusch.

Regarding gains: as part of the migration to docsy there'll be some cleanup done. If this release URL isn't being used, then it's like dead code -- it adds cruft w/o value. There's enough complexity in this site w/o having to keep unused features.

Ok, let's put this on hold for now. I'll revisit later after the docsy migration.

@chalin chalin added e0-minutes Effort: < 60 min p3-low labels Nov 18, 2020
@jtattermusch
Copy link
Contributor

I've investigated the use of the grpc.io/release file and it seems that we can get rid of it.

The only use I've found is in the go/grpc-release doc (internal only) and I can remove those references once a PR exists to remove the logic for generating the grpc.io/release content.

@chalin chalin added p2-medium and removed question Further information is requested p3-low labels Nov 23, 2020
@chalin chalin changed the title Drop the site's release file? Drop the site's release file Nov 23, 2020
chalin added a commit that referenced this issue Nov 23, 2020
@chalin chalin mentioned this issue Nov 23, 2020
@chalin
Copy link
Collaborator Author

chalin commented Nov 23, 2020

... I can remove those references once a PR exists to remove the logic for generating the grpc.io/release content.

Done, see #542

chalin added a commit that referenced this issue Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e0-minutes Effort: < 60 min p2-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants