Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct release tag #80

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Correct release tag #80

merged 2 commits into from
Feb 4, 2020

Conversation

gnossen
Copy link
Collaborator

@gnossen gnossen commented Feb 4, 2020

This is an alternative to grpc/grpc#21891.

Tested locally.

@gnossen gnossen mentioned this pull request Feb 4, 2020
Merged
srini100
srini100 approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@srini100 srini100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work figuring this out quickly!

@srini100 srini100 merged commit 7e08e82 into grpc:master Feb 4, 2020
@srini100
Copy link
Contributor

srini100 commented Feb 5, 2020

Works after merging.

@gnossen gnossen deleted the correct_release_tag branch February 5, 2020 00:32
@chalin chalin mentioned this pull request Nov 6, 2020
Closed
@ejona86 ejona86 mentioned this pull request Feb 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srini100 srini100 srini100 approved these changes

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnossen @srini100