Make db property read-only #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsalgado throwing an early PR out there to see if I'm understanding the issue correctly. I would also love to write a unit test for this but don't understand what object to pass to the VM class to instantiate it. Thanks. |
ghost
mentioned this pull request
|
Sorry, @egong but ethereum#80 is about having a class that wraps a BaseDB object and only allows read-only methods (e.g. .get(), .exists()) to be called on it. |
ghost
closed this
ghost
mentioned this pull request
gsalgado
pushed a commit
that referenced
this pull request
May 25, 2018
# This is the 1st commit message: fixes ethereum#760 ethereum#762 ethereum#737 # The commit message #2 will be skipped: # use eth-utils big endian integer utils # The commit message #3 will be skipped: # Fix IndexError when an empty bucket is encountered while looking up nodes # The commit message #4 will be skipped: # dirty
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Implement read-only wrapper for vm.db raising an error if write operations are attempted
https://github.com/pipermerriam/py-evm/issues/80
How was it fixed?
Made the db a property of the class
Cute Animal Picture