Create Basedb class to wrap db object #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsalgado Am I on the right track this time? Would appreciate if you could explain what the DB object is in the first place. It might help me make more sense of the task. |
|
@egong the BaseDB I referred to is the one in evm/db/backends/base.py |
|
@gsalgado trying again with this latest commit. please walk me through more if I'm not understanding properly, thanks. would love to reach success on this task. |
|
Sorry, @egong, I don't have the time to help you with this. I suggest you create the PR on the upstream repo as maybe somebody else would be able to help you |
gsalgado
pushed a commit
that referenced
this pull request
May 25, 2018
# This is the 1st commit message: fixes ethereum#760 ethereum#762 ethereum#737 # The commit message #2 will be skipped: # use eth-utils big endian integer utils # The commit message #3 will be skipped: # Fix IndexError when an empty bucket is encountered while looking up nodes # The commit message #4 will be skipped: # dirty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Another attempt to create the BaseDB wrapper
How was it fixed?
Created a class to get early feedback if in right direction
Cute Animal Picture
IOU