Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hex color for basic theme instead of color wheel #1428

Closed
lamyergeier opened this issue Sep 6, 2021 · 3 comments · Fixed by #2203
Closed

Hex color for basic theme instead of color wheel #1428

lamyergeier opened this issue Sep 6, 2021 · 3 comments · Fixed by #2203
Labels
feature good first issue help wanted
Milestone
Markor v2.13

Comments

@lamyergeier
Copy link

lamyergeier commented Sep 6, 2021 •
edited
Loading

General information

  • App version: 2.8.0
  • Android version: 11
  • Device: Samsung A70
  • I understand that this issue will be closed without further notice in case I didn't describe the problem including general information, or didn't search for similar issues & requests.

Description

In the following I would like to change BG Light to #fdf6e3, how can I type it instead of choosing it from the colour wheel. May be you could provide an option to type it under the colour wheel.

Screenshot_20210906-173427_Markor
@gsantner gsantner mentioned this issue Sep 8, 2021
Closed
@gsantner gsantner changed the title Ability to type hexcode to define colors of color scheme Enter hexcode color for basic theme instead of color wheel Sep 8, 2021
@gsantner gsantner changed the title Enter hexcode color for basic theme instead of color wheel Hex color for basic theme instead of color wheel Sep 8, 2021
@gsantner gsantner added this to the Community Contribution milestone Sep 8, 2021
@jayunx
Copy link

jayunx commented Apr 24, 2022

Dear Developer, I wanna help fix this issue, but I have not found the place to fix. I wanna know which files I can read now, plz.

@gsantner
Copy link
Owner

In main/java/net/gsantner/markor/ui/hleditor/TextActions.java is a action to show a color dialog. We want to use something else there to input #hex color and visualize the input color there instead [..the color wheel isn't optimal for the use].

@jayunx
Copy link

jayunx commented Apr 24, 2022

In main/java/net/gsantner/markor/ui/hleditor/TextActions.java is a action to show a color dialog. We want to use something else there to input #hex color and visualize the input color there instead [..the color wheel isn't optimal for the use].

Thank you. I got your meaning.

@gsantner gsantner pinned this issue Nov 5, 2022
@gsantner gsantner linked a pull request Jan 11, 2024 that will close this issue
New Color picker, minsdk 16-18, closes #1428 #2203
Merged
@gsantner gsantner unpinned this issue Mar 27, 2024
gsantner pushed a commit to halfdane/markor that referenced this issue Jul 27, 2024
@halfdane @gsantner
fixes gsantner#1428 by introducing a new color picker
7d83fb9
elyahw pushed a commit to writing-tools/marelias-notepad that referenced this issue Sep 26, 2024
@halfdane @elyahw
New Color picker, bump Android minSdk from 16 to 18, closes gsantner#…
8f07ede 
…1428 (PR gsantner#2203 by @halfdane)

* fixes gsantner#1428 by introducing a new color picker

* Update preferences_master.xml

* Restore preference

---------

Co-authored-by: Gregor Santner <gsantner@mailbox.org>
(cherry picked from commit 19e0cdc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue help wanted
Projects
None yet
Milestone
Markor v2.13
Development

Successfully merging a pull request may close this issue.

New Color picker, minsdk 16-18, closes #1428 halfdane/markor
3 participants
@gsantner @lamyergeier @jayunx