Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Color picker, minsdk 16-18, closes #1428 #2203

Merged
merged 4 commits into from
Jul 27, 2024
Merged

Conversation

halfdane
Copy link
Contributor

  1. Introduces martin stone's colorpicker as a replacement for quadflask's.
  2. Removes the obsolete 3rd-party quadflask code
  3. Removes an unused method with a dependency to the quadflask code
  4. Bumps the minSDK from 16 to 18

Since I'm not intimately familiar with this code (or any android code), please make sure I didn't inadvertently breack stuff with the removal of (probably?) unused code or the version bump.

@gsantner
Copy link
Owner

gsantner commented Jan 11, 2024

Hello thank you for your help!

As you asking about breaking, these things are especially important to work: Color picking at editor (insert color i.e.) and at the settings (picking background color in basic scheme for example). It should be made sure that the value correctly shows/restores/saves and also loads it as such.

You can also change the saving format (color saved to AppSettings/SharedPreferences) if it makes something easier. Users can re-pick the colors. It's just important that it applies and is correctly remembered from then on.

@gsantner gsantner changed the title fixes #1428 by introducing a new color picker New Color picker, closes #1428 Jan 11, 2024
@gsantner gsantner linked an issue Jan 11, 2024 that may be closed by this pull request
@halfdane
Copy link
Contributor Author

I have checked that the picker works correctly in basic color scheme settings, but that seems to be the only place where a color picker is used: I don't know how to do "Color picking at editor (insert color i.e.)", so if you could point me to the right place in the UI, I'll gladly check.

@gsantner
Copy link
Owner

I have checked that the picker works correctly in basic color scheme settings, but that seems to be the only place where a color picker is used: I don't know how to do "Color picking at editor (insert color i.e.)", so if you could point me to the right place in the UI, I'll gladly check.

There was a "Attachment" button and dialog, which currently seems to be removed or at last doesn't work. There were quite a few changes on that part recently and it's being reworked.

The point is, does the new library support showing a color picker dialog and get the color string out, so it can be inserted in the text document?

@gsantner
Copy link
Owner

Want to merge this after the upcoming update, so it still goes by the old minsdk version and the big mass of changes reaches also users with old devices.

@gsantner gsantner added this to the Markor v2.13 milestone Mar 27, 2024
@gsantner gsantner changed the title New Color picker, closes #1428 New Color picker, minsdk 16-18, closes #1428 Mar 27, 2024
@@ -13,7 +13,7 @@ if (enable_plugin_kotlin) {
apply plugin: 'kotlin-kapt'
}

rootProject.ext.version_minSdk = 16
rootProject.ext.version_minSdk = 18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {

in our codebase. May be good to remove them if we are bumping versions

Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it's time to drop the dated color picker. Merging

@gsantner gsantner merged commit 19e0cdc into gsantner:master Jul 27, 2024
1 check passed
elyahw pushed a commit to writing-tools/marelias-notepad that referenced this pull request Sep 26, 2024
…1428 (PR gsantner#2203 by @halfdane)

* fixes gsantner#1428 by introducing a new color picker

* Update preferences_master.xml

* Restore preference

---------

Co-authored-by: Gregor Santner <gsantner@mailbox.org>
(cherry picked from commit 19e0cdc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hex color for basic theme instead of color wheel
3 participants