-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Color picker, minsdk 16-18, closes #1428 #2203
Conversation
Hello thank you for your help! As you asking about breaking, these things are especially important to work: Color picking at editor (insert color i.e.) and at the settings (picking background color in basic scheme for example). It should be made sure that the value correctly shows/restores/saves and also loads it as such. You can also change the saving format (color saved to AppSettings/SharedPreferences) if it makes something easier. Users can re-pick the colors. It's just important that it applies and is correctly remembered from then on. |
I have checked that the picker works correctly in basic color scheme settings, but that seems to be the only place where a color picker is used: I don't know how to do "Color picking at editor (insert color i.e.)", so if you could point me to the right place in the UI, I'll gladly check. |
There was a "Attachment" button and dialog, which currently seems to be removed or at last doesn't work. There were quite a few changes on that part recently and it's being reworked. The point is, does the new library support showing a color picker dialog and get the color string out, so it can be inserted in the text document? |
Want to merge this after the upcoming update, so it still goes by the old minsdk version and the big mass of changes reaches also users with old devices. |
@@ -13,7 +13,7 @@ if (enable_plugin_kotlin) { | |||
apply plugin: 'kotlin-kapt' | |||
} | |||
|
|||
rootProject.ext.version_minSdk = 16 | |||
rootProject.ext.version_minSdk = 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
in our codebase. May be good to remove them if we are bumping versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it's time to drop the dated color picker. Merging
…1428 (PR gsantner#2203 by @halfdane) * fixes gsantner#1428 by introducing a new color picker * Update preferences_master.xml * Restore preference --------- Co-authored-by: Gregor Santner <gsantner@mailbox.org> (cherry picked from commit 19e0cdc)
Since I'm not intimately familiar with this code (or any android code), please make sure I didn't inadvertently breack stuff with the removal of (probably?) unused code or the version bump.