codegen/build.rs: disable print_system_libs in calls to pkg-config #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
|
Thanks |
vhdirk
pushed a commit
to vhdirk/gir
that referenced
this pull request
Jul 6, 2018
codegen/build.rs: disable print_system_libs in calls to pkg-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS
environment variable
(rust-lang/pkg-config-rs#35), which leads
to eg /usr/lib being present in the middle of the final command,
in turn leading to issues when working in an uninstalled environment,
where libraries that are also present system-wide do not get linked
against.