-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't force PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 #35
Conversation
Thanks for the PR! Regardless of whether this idea was good or not it's part of the stable interface of pkg-config and I'd prefer to not have a breaking change just yet. Perhaps a boolean option could be added though to disable this behavior? |
I'd say it's really easy to add the env variable should a user need it ? I agree this is a breaking change though... |
To be clear, this is a breaking change, so it can't be merged as-is. We can add a boolean option to the builder, however, to disable this and perhaps change the default behavior in the next major version. |
It is possible to work around this by using a different part of the pkg-config API. But non-obvious. |
Added in d184e48 |
+1 for making this the default, the current behaviour is pretty broken when multiple versions of the same library are present |
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
For some reason pkg-config-rs sets PKG_CONFIG_ALLOW_SYSTEM_LIBS by default, breaking uninstalled builds, see rust-lang/pkg-config-rs#35 Users should manually enable this if needed, by defining the env variable, and should not be enforced by the build system.
For some reason pkg-config-rs sets PKG_CONFIG_ALLOW_SYSTEM_LIBS by default, breaking uninstalled builds, see rust-lang/pkg-config-rs#35 Users should manually enable this if needed, by defining the env variable, and should not be enforced by the build system.
For some reason pkg-config-rs sets PKG_CONFIG_ALLOW_SYSTEM_LIBS by default, breaking uninstalled builds, see rust-lang/pkg-config-rs#35 Users should manually enable this if needed, by defining the env variable, and should not be enforced by the build system.
No idea if this change in behavior is acceptable. Seems like a bad default, though.
Per #11 (comment)