gtk: Cleanup template related functions #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composite template macro uses gtk_widget_class_bind_template_child_full instead It is not useful for us, so better avoid a mis-usage of it.
and rename it to CompositeTemplateInitializingExt to make it clear it is limited to CompositeTemplate use cases
By moving it to CompositeTemplateExt where it makes more sense and allows us to drop the glib::Type parameter
Not useful for us as you can acess the struct fields that are wrapped with TemplateChild<T>
|
That's of course not backwards compatible so don't backport that :) |
yes, that is why i didn't add the corresponding label |
sdroege
reviewed
Dec 9, 2022
| @@ -372,10 +372,6 @@ pub trait WidgetExt: 'static { | |||
| #[doc(alias = "get_style_context")] | |||
| fn style_context(&self) -> StyleContext; | |||
|
|
|||
| #[doc(alias = "gtk_widget_get_template_child")] | |||
| #[doc(alias = "get_template_child")] | |||
| fn template_child(&self, widget_type: glib::types::Type, name: &str) -> glib::Object; | |||
There was a problem hiding this comment.
Doesn't hurt to have it, does it?
There was a problem hiding this comment.
There is no point in having it, you can retrieve child widgets with #[template_child]. This is probably a helper for languages like Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1189