Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk: Cleanup template related functions #1212

Merged
merged 5 commits into from
Dec 9, 2022
Merged

gtk: Cleanup template related functions #1212

merged 5 commits into from
Dec 9, 2022

Commits on Dec 9, 2022

  1. gtk: Drop WidgetClassSubclassExt::bind_template_child 

    Composite template macro uses gtk_widget_class_bind_template_child_full instead
It is not useful for us, so better avoid a mis-usage of it.
    @bilelmoussaoui
    bilelmoussaoui committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4b92643 View commit details
    Browse the repository at this point in the history

  2. gtk: Move InitializingWidgetExt to subclass prelude 

    and rename it to CompositeTemplateInitializingExt to make it clear
it is limited to CompositeTemplate use cases
    @bilelmoussaoui
    bilelmoussaoui committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    bc31a90 View commit details
    Browse the repository at this point in the history

  3. gtk: Manually implement WidgetExt::dispose_template 

    By moving it to CompositeTemplateExt where it makes more sense and
allows
us to drop the glib::Type parameter
    @bilelmoussaoui
    bilelmoussaoui committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b8c1ca3 View commit details
    Browse the repository at this point in the history

  4. gtk: Drop WidgetExt::get_template_child 

    Not useful for us as you can acess the struct fields that are wrapped with TemplateChild<T>
    @bilelmoussaoui
    bilelmoussaoui committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    9a7095f View commit details
    Browse the repository at this point in the history

  5. examples: Make use of dispose_template

    @bilelmoussaoui
    bilelmoussaoui committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    2047d99 View commit details
    Browse the repository at this point in the history