Skip to content

Conversation

ioannakok
Copy link
Contributor

@ioannakok ioannakok commented Sep 23, 2025

Closes #14524

What does this change?

Adds a camera or video icon in galleries main media caption in lower breakpoints.

Why?

It make more clear to what the caption is referring to.

Screenshots

Before After
image image

Copy link

github-actions bot commented Sep 23, 2025

Copy link

github-actions bot commented Sep 23, 2025

@ioannakok
Copy link
Contributor Author

ioannakok commented Sep 29, 2025

@ioannakok ioannakok closed this Sep 29, 2025
@ioannakok ioannakok reopened this Sep 29, 2025
@ioannakok
Copy link
Contributor Author

ioannakok commented Sep 30, 2025

Re-opening because

will be dealt as separate changes after we go live.

@ioannakok ioannakok added the run_chromatic Runs chromatic when label is applied label Sep 30, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 30, 2025
@ioannakok ioannakok marked this pull request as ready for review September 30, 2025 08:57
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@ioannakok ioannakok added the run_chromatic Runs chromatic when label is applied label Sep 30, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 30, 2025
Copy link
Contributor

@marjisound marjisound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

@marjisound marjisound added the run_chromatic Runs chromatic when label is applied label Sep 30, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 30, 2025
@marjisound marjisound added the run_chromatic Runs chromatic when label is applied label Sep 30, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 30, 2025
@ioannakok ioannakok merged commit 78c302b into main Sep 30, 2025
31 checks passed
@ioannakok ioannakok deleted the add-image-for-galleries-main-image-caption branch September 30, 2025 14:19
@gu-prout
Copy link

gu-prout bot commented Sep 30, 2025

Seen on PROD (merged by @ioannakok 12 minutes and 8 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine If Main Media Captions on Galleries and Immersives Should Include "Main Image:"
2 participants