Skip to content

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Oct 3, 2025

What does this change?

  • Shares z-index value for edition switcher banner and sticky labs header
  • Provides this z-index value as a prop in the Stuck component for the LabsHeader on articles

Why?

Fixes a bug where the edition dropdown menu expanded underneath the sticky labs header

Screenshots

Before After
before after

@cemms1 cemms1 added Commercial 💰 fix Core 4 Metric - label: FIX, colour: #fc0394 labels Oct 3, 2025
@github-actions github-actions bot added dotcom-rendering and removed Commercial 💰 fix Core 4 Metric - label: FIX, colour: #fc0394 labels Oct 3, 2025
@cemms1 cemms1 added Commercial 💰 fix Core 4 Metric - label: FIX, colour: #fc0394 labels Oct 3, 2025
Copy link

github-actions bot commented Oct 3, 2025

Copy link

github-actions bot commented Oct 3, 2025

@cemms1 cemms1 force-pushed the cemms1/fix-sticky-labs-header-zindex branch 2 times, most recently from 7bd9605 to 680b8d9 Compare October 6, 2025 07:57
@cemms1 cemms1 force-pushed the cemms1/fix-sticky-labs-header-zindex branch from 680b8d9 to 5c45918 Compare October 6, 2025 07:57
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Oct 6, 2025
@cemms1 cemms1 requested a review from a team October 6, 2025 08:00
@cemms1 cemms1 marked this pull request as ready for review October 6, 2025 08:00
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 6, 2025
@cemms1 cemms1 merged commit 63601fe into main Oct 6, 2025
32 checks passed
@cemms1 cemms1 deleted the cemms1/fix-sticky-labs-header-zindex branch October 6, 2025 09:56
@gu-prout
Copy link

gu-prout bot commented Oct 6, 2025

Seen on PROD (merged by @cemms1 8 minutes and 52 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Commercial 💰 dotcom-rendering fix Core 4 Metric - label: FIX, colour: #fc0394 Seen-on-PROD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants