Skip to content

Share z-index value for edition switcher banner and sticky labs header #14612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
+11 −11
Merged

Share z-index value for edition switcher banner and sticky labs header #14612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotcom-rendering/src/components/EditionSwitcherBanner.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const container = css`
position: relative;
top: 0;
background-color: ${palette.brand[800]};
z-index: ${getZIndex('editionSwitcherBanner')};
z-index: ${getZIndex('subNavBanner')};
`;

const content = css`
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/AudioLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export const AudioLayout = (props: WebProps) => {
</div>

{format.theme === ArticleSpecial.Labs && (
<Stuck>
<Stuck zIndex="subNavBanner">
<Section
fullWidth={true}
showTopBorder={false}
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/FullPageInteractiveLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export const FullPageInteractiveLayout = (props: WebProps | AppsProps) => {
/>

{format.theme === ArticleSpecial.Labs && (
<Stuck>
<Stuck zIndex="subNavBanner">
<Section
fullWidth={true}
showTopBorder={false}
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/GalleryLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ export const GalleryLayout = (props: WebProps | AppProps) => {
)}

{format.theme === ArticleSpecial.Labs && (
<Stuck>
<Stuck zIndex="subNavBanner">
<Section
fullWidth={true}
showTopBorder={false}
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/ImmersiveLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ export const ImmersiveLayout = (props: WebProps | AppProps) => {
)}

{format.theme === ArticleSpecial.Labs && (
<Stuck>
<Stuck zIndex="subNavBanner">
<Section
fullWidth={true}
showTopBorder={false}
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/InteractiveLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ export const InteractiveLayout = (props: WebProps | AppsProps) => {
</div>

{format.theme === ArticleSpecial.Labs && (
<Stuck>
<Stuck zIndex="subNavBanner">
<Section
fullWidth={true}
showTopBorder={false}
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/ShowcaseLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ export const ShowcaseLayout = (props: WebProps | AppsProps) => {
/>
</Stuck>
</div>
<Stuck zIndex="stickyAdWrapperLabsHeader">
<Stuck zIndex="subNavBanner">
<Section
fullWidth={true}
showTopBorder={false}
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/StandardLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ export const StandardLayout = (props: WebProps | AppProps) => {
)}

{format.theme === ArticleSpecial.Labs && (
<Stuck>
<Stuck zIndex="subNavBanner">
<Section
fullWidth={true}
showTopBorder={false}
Expand Down
6 changes: 3 additions & 3 deletions dotcom-rendering/src/lib/getZIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ const indices = [
'searchHeaderLink',
'TheGuardian',

// The edition switcher banner needs to be below the Edition selector
// and the myAccount dropdown in the nav
'editionSwitcherBanner',
// Banners appearing directly under the nav need to be below
// the Edition selector and the myAccount dropdown in the nav
'subNavBanner',

// Sticky table of contents element
'tableOfContents',
Expand Down
Loading