Performance monitoring: Islands #5296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4.79 kB (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
OllysCoding
reviewed
Jul 4, 2022
| @@ -5974,7 +5974,7 @@ | |||
| "find-up": { | |||
| "version": "2.1.0", | |||
| "resolved": "https://registry.npmjs.org/find-up/-/find-up-2.1.0.tgz", | |||
| "integrity": "sha1-RdG35QbHF93UgndaK3eSCjwMV6c=", | |||
There was a problem hiding this comment.
We really need to look into why these keep switching between sha1 and sha512 - it's very weird @JamieB-gu @marsavar
OllysCoding
reviewed
Jul 4, 2022
- Removed systematic console logs - Removed dependency on getEntriesByName - Return time elapsed since time origin for start() - Add some documentation
Hopefully gaining more insight into where improvements would be beneficial. Now logging to the console the duration of: - rendering or hydration - downloading the island’s JavaScript
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Refactor
initPerfto simplify and shorten the code. Stop logging willy-nilly for data that we never look at.Log islands performance info: how long it took then to render or hydrate, how long to download their JavaScript.
Chore: bump lockfiles.
Why?
We need more fine-grained information about our Islands hydration. In order to know which ones are performing best and worse, and start enforcing budget, we need information broken down by Island.
Related
Screenshots