-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix buggy implementations of the Performance API #5299
Conversation
performance.measure
is undefined
Size Change: +1.06 kB (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 pending tests in code
1c615cb
to
be69119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Many errors have started showing in Sentry since the island performance changes have been introduced: CLIENT-SIDE-PROD-CTP6 We now make guard against these three `performance.` cases: - the browser does not support `getEntriesByName` - the browser does not return a PerformanceEntry from `mark` & `measure` - no PerformanceEntry was found when running `getEntriesByName`
performance.measure
is undefined
What does this change?
Fallback to returning bogus (no-op) functions on initPerf when
performance.getEntriesByName
is missing.Many errors have started showing in Sentry since the island performance changes have been introduced.
Looking for the existence of
measure
in window.performance should be a better indicator of support than simplymark
.Why?
The behaviour has been refactored in:
Screenshots