fix: safe performance.getEntriesByType
#5849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
changed the title
performance.getEntriesByType
Some browsers do not support this method, so we check for its existence before measuring the time taken. Fixes CLIENT-SIDE-PROD-CSXR Fixes CLIENT-SIDE-PROD-CTRH
mxdvl
force-pushed
the
mxdvl/safe-get-entries-by-type
branch
from
4370130
to
a64ff08
Compare
|
I guess there are a few non-equivalent ways of checking whether an object has a property/method in js, right? I'm never clear on exactly which to use when. |
|
Size Change: +25 B (0%) Total Size: 1.65 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
Thanks for the question. The fact that you raised this means we might have to capture this information more clearly. I will merge this PR now we can use issue #5853 to discuss this further. The reason I am using the window.performance.getEntriesByType?.('measure');
// Via https://typescript-eslint.io/rules/no-unnecessary-condition/ ESLint auto-fixes to:
window.performance.getEntriesByType('measure');An alternative would be to disable that rule locally, which might be more explicit? What do you think, @bryophyta: // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- not all browsers
window.performance.getEntriesByType?.('measure'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Some browsers do not support
window.performance.getEntriesByType, so we check for its existence before measuring the time taken.Why?
This is the top reported
TypeErrorin Sentry.Fixes CLIENT-SIDE-PROD-CSXR
Fixes CLIENT-SIDE-PROD-CTRH
This method was Introduced in #5298.
Related to the fix in #5299