Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe card type to the Feast platform #1570

Merged
merged 13 commits into from
May 9, 2024

Conversation

jonathonherbert
Copy link
Contributor

@jonathonherbert jonathonherbert commented Apr 29, 2024

co-authored-by: @Divs-B

What's changed?

Adds a recipe card type to the Feast platform. It's useable when you're editing Feast editions.

We've added some fixture data that's visible in the Feed on the left hand side to get us started. This will eventually be powered by recipe-backend search.

We've added the minimum possible to test this from client to server and back again:

  • ✅ add a new recipe CardType to the server-side enum
  • ✅ recipe feed cards in client
  • ✅ support for recipe drag-and-drop behaviour
  • ✅ correctly persisting card type information on collection update
  • ❌ recipe card representation in collections (in the gif, note the blank cards in the Front) – this will come in a future PR
  • ❌ the hover links to the external resource, and Ophan, don't work. The hover button components need a refactor for this to work, and we thought this'd be better as a separate PR.

Here's a GIF of it in action. The UI is incomplete, but proves that we can see recipes in the feed, drag them into collections, and have them persist (note the page refresh – the data loads and is correct.) We don't have any users yet, so we are able to ship work in this state 🎨 🔥

add-recipes

I've checked that cards in Fronts and Editions for articles, snaplinks etc. work as normal.

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE (proofed Edition to prove publication is still ok 👌)

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@jonathonherbert jonathonherbert requested a review from a team as a code owner April 29, 2024 13:13
@jonathonherbert jonathonherbert marked this pull request as draft April 29, 2024 13:13
@jonathonherbert jonathonherbert changed the base branch from main to jsh/editions-article-to-card April 29, 2024 13:13
@jonathonherbert jonathonherbert marked this pull request as ready for review April 29, 2024 16:50
Base automatically changed from jsh/editions-article-to-card to main May 7, 2024 08:24
@jonathonherbert jonathonherbert force-pushed the jsh-db/add-recipe-card branch 2 times, most recently from a1a28b8 to 71ce0c6 Compare May 8, 2024 09:46
Copy link
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I haven’t run it, but I’m convinced by the gif and checklist.

@jonathonherbert jonathonherbert merged commit 809654e into main May 9, 2024
8 checks passed
@jonathonherbert jonathonherbert deleted the jsh-db/add-recipe-card branch May 9, 2024 09:29
@prout-bot
Copy link

Seen on PROD (merged by @jonathonherbert 6 minutes and 25 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants