Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chef card type to the Feast Platform #1576

Merged
merged 11 commits into from
May 10, 2024
Merged

Add Chef card type to the Feast Platform #1576

merged 11 commits into from
May 10, 2024

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented May 7, 2024

What's changed?

(Reference is derived from recipe-card work done by @jonathonherbert on PR #1570 and PR #1571 )

Adds a chef card type to the Feast platform to facilitate searching and editing on Chef on Feast Editions.

We've added some fixture data that's visible in the Feed on the left hand side to get us started. This will eventually be powered by recipe-backend search.

At present, Chefs are displayed under the Recipe fixture data. This will change once Chef search action and UI gets finalised.

Screen.Recording.2024-05-07.at.11.22.16.mov

Implementation notes

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@Divs-B Divs-B changed the base branch from main to jsh-db/add-recipe-card-to-collection May 7, 2024 11:36
@jonathonherbert jonathonherbert force-pushed the jsh-db/add-recipe-card-to-collection branch 4 times, most recently from a7de1b7 to 95115a4 Compare May 9, 2024 09:39
@Divs-B Divs-B marked this pull request as ready for review May 9, 2024 14:50
@Divs-B Divs-B requested a review from a team as a code owner May 9, 2024 14:50
Base automatically changed from jsh-db/add-recipe-card-to-collection to main May 9, 2024 14:59
Copy link
Contributor

@jonathonherbert jonathonherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and in CODE, looks great! ✨

I hope you don't mind – I've rebased from main to save rebasing a tedious diff.

@jonathonherbert jonathonherbert merged commit dfc20da into main May 10, 2024
9 checks passed
@jonathonherbert jonathonherbert deleted the db/add-chef branch May 10, 2024 10:14
@prout-bot
Copy link

Seen on PROD (created by @Divs-B and merged by @jonathonherbert 6 minutes and 1 second ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants