Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Java 11 for SBT Snyk job and remove Java option from non SBT job #1581

Merged
merged 1 commit into from
May 15, 2024
Merged

Specify Java 11 for SBT Snyk job and remove Java option from non SBT job #1581

merged 1 commit into from
May 15, 2024

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented May 15, 2024 •
edited
Loading

What's changed?

The first Snyk job (snyk-v2-and-scala) hasn't been running properly since this commit

  • Specifies Java version 11 rather than 8 in main Snyk job (snyk-V2-and-scala) which seems to fix the broken job
  • Removes Java option from non SBT Snyk job (snyk-V1-only)

Implementation notes

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@cemms1 cemms1 changed the title Specify Java 11 for SBT Sny snyk job and remove java from non sbt snyk job Specify Java 11 for SBT Snyk job and remove Java option from non SBT job May 15, 2024
@cemms1 cemms1 marked this pull request as ready for review May 15, 2024 10:31
@cemms1 cemms1 requested a review from a team as a code owner May 15, 2024 10:31
@github-actions GitHub Actions
Copy link

Deploy build 8058 of cms-fronts::facia-tool to CODE

All deployment options

From guardian/actions-riff-raff.

davidfurey
davidfurey approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@davidfurey davidfurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry I missed this

@cemms1 cemms1 merged commit 5534d77 into main May 15, 2024
11 checks passed
@cemms1 cemms1 deleted the cemms1/fix-snyk branch May 15, 2024 12:21
@prout-bot
Copy link

Seen on PROD (merged by @cemms1 10 minutes and 44 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfurey davidfurey davidfurey approved these changes

Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemms1 @prout-bot @davidfurey