Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Java 11 for SBT Snyk job and remove Java option from non SBT job #1581

Merged
merged 1 commit into from
May 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/snyk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
uses: guardian/.github/.github/workflows/sbt-node-snyk.yml@main
with:
ORG: guardian
JAVA_VERSION: 8
JAVA_VERSION: 11
EXCLUDE: package-lock.json # exclude V1, since it has its own special job below (because of JSPM)
secrets:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
Expand All @@ -22,7 +22,6 @@ jobs:
uses: guardian/.github/.github/workflows/sbt-node-snyk.yml@main
with:
ORG: guardian
JAVA_VERSION: 8
EXCLUDE: fronts-client # exclude V2, since it's captured by the main job above
SKIP_SBT: true # exclude scala, since it's captured by the main job above
NODE_PACKAGE_JSON_FILES_MISSING_LOCK: v1_jspm_snyk_workaround/package.json v1_jspm_snyk_workaround/result/package.json
Expand Down
Loading