Move from JavaMail to JakartaMail #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srbd
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Most of the work in this PR was done by @srbd
JavaMail has reached end of life and has been replaced by jakarta mail. This PR introduces jakarta mail to Giant, including the Mbox provider JAR file which has to be manually compiled and checked in (see https://eclipse-ee4j.github.io/angus-mail/Mbox-Store)
Unfortunately, we've yet to succesfully ingest an mbox file using either jakarta mail or the latest version of java mail. Our assumption is that MBOX is a poorly defined format, so it's hard to get something that works for all MBOX files. The motivation for this PR isn't to actually fix anything :( but I have tested it with a normal .EML file which it appears to handle without any problems - so it shouldn't be making anything worse!
How to test
Tested on playground, seems to exhibit the same behaviour as JavaMail..!
How can we measure success?
We'll benefit from future updates to jakarta mail