Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading bouncycastle and including javax.mail as a dependency #207

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

srbd
Copy link
Contributor

@srbd srbd commented Apr 19, 2024

  • There were runtime errors that occured during a large ingest for a missing field sphincsPlus_shake_256.
    Bumping bouncycastle to 1.71 solved this (bumping to latest version 1.79 didn't work as it does not have the field).

  • We previously expected angus-mail (as an implementation of jakartamail) (see Move from JavaMail to JakartaMail #131) to work as a drop-in replacement for javax.mail but there still seems to be a dependency on javax.mail, so we've added it. Not including it resulted in NoClassDefFoundError: javax/mail/Part

Testing

Tested on a local instance

…sPlus_shake_256 (bumping to latest version 1.79 doesn't work as it does not have the field). Including javax.mail as a dependency - not including it resulted in NoClassDefFoundError: javax/mail/Part
@srbd srbd requested a review from a team as a code owner April 19, 2024 10:02
@philmcmahon
Copy link
Contributor

Full stack trace for javax.mail issue:

Uncaught error from thread [pfi-work-context-58]: javax/mail/Part, shutting down JVM since 'pekko.jvm-exit-on-fatal-error' is enabled for ActorSystem[pfi]
java.lang.NoClassDefFoundError: javax/mail/Part
    at java.base/java.lang.Class.getDeclaredConstructors0(Native Method)
    at java.base/java.lang.Class.privateGetDeclaredConstructors(Class.java:3137)
    at java.base/java.lang.Class.getConstructor0(Class.java:3342)
    at java.base/java.lang.Class.getConstructor(Class.java:2151)
    at jakarta.activation.MailcapCommandMap.getDataContentHandler(MailcapCommandMap.java:620)
    at jakarta.activation.MailcapCommandMap.createDataContentHandler(MailcapCommandMap.java:573)
    at jakarta.activation.CommandMap.createDataContentHandler(CommandMap.java:210)
    at jakarta.activation.DataHandler.getDataContentHandler(DataHandler.java:588)
    at jakarta.activation.DataHandler.getContent(DataHandler.java:515)
    at jakarta.mail.internet.MimeMessage.getContent(MimeMessage.java:1502)
    at extraction.email.eml.EmlParser.parseMessage(EmlParser.scala:43)
    at extraction.email.eml.EmlEmailExtractor.$anonfun$extract$1(EmlEmailExtractor.scala:32)
    at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
    at cats.syntax.EitherObjectOps$.catchNonFatal$extension(either.scala:370)
    at extraction.email.eml.EmlEmailExtractor.extract(EmlEmailExtractor.scala:26)
    at extraction.Worker.safeInvokeExtractor(Worker.scala:134)
    at extraction.Worker.$anonfun$executeBatch$2(Worker.scala:88)
    at scala.util.Either.flatMap(Either.scala:352)
   

Copy link
Contributor

@philmcmahon philmcmahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bouncycastle

@srbd srbd merged commit d29fa0c into main Apr 19, 2024
1 check passed
@srbd srbd deleted the sbd-fix-dependencies branch April 19, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants