Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run sbt commands in CI via a script #68

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Run sbt commands in CI via a script #68

merged 3 commits into from
Jun 8, 2022

Conversation

jacobwinch
Copy link
Contributor

@jacobwinch jacobwinch commented Jun 8, 2022

What does this change?

Addresses #64 (comment). Moving all CI configuration into version control is generally desirable. For example, it will make it easier to review & apply all changes related to #64, as there will no longer be additional steps required in TeamCity.

I've deployed this to CODE and confirmed that it works as expected.

Once this PR is merged I will tidy up the TeamCity build configuration.

@@ -1,5 +1,5 @@
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.6")

addSbtPlugin("com.gu" % "sbt-riffraff-artifact" % "1.1.7")
addSbtPlugin("com.gu" % "sbt-riffraff-artifact" % "1.1.18")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the old version TeamCity wasn't picking up the build number correctly; this upgrade fixes that problem.

@jacobwinch jacobwinch marked this pull request as ready for review June 8, 2022 10:52

set -e

sbt "project mobile-save-for-later; clean; compile; riffRaffUpload"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently running via this build step, which I've disabled for now.

Copy link
Contributor

@DavidLawes DavidLawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense to me

I notice that other projects we have (e.g. mapi, mobile-save-for-later-user-deletion) define their build steps in team city, as opposed to defining them in code. Is this a task we need on our backlog?

@jacobwinch
Copy link
Contributor Author

jacobwinch commented Jun 8, 2022

I notice that other projects we have (e.g. mapi, mobile-save-for-later-user-deletion) define their build steps in team city, as opposed to defining them in code. Is this a task we need on our backlog?

It would be good to do this but it's not especially urgent. Hopefully we will start moving Scala projects to GitHub Actions in the next few months (we aren't recommending this to all teams just yet due to some performance concerns) and that migration will solve this type of problem too.

@jacobwinch jacobwinch merged commit dc03f05 into master Jun 8, 2022
@jacobwinch jacobwinch deleted the jw-ci branch June 8, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants