-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @guardian/cdk to repository and deploy stage-specific templates #64
Conversation
Could we bring the CI build steps into the VCS? We're currently using the sbt runner in TeamCity, which IIRC isn't great as it always exits 0, even when there are failing tests 😱 . |
Sure, will raise a new PR for that and then rebase this one. Update: this has been done in #68. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great to me!
ddbb924
to
d41367a
Compare
ae6ebba
to
680082d
Compare
What does this change?
We are migrating the
mobile-save-for-later
service from CloudFormation to@guardian/cdk
. The migration will involve 5 PRs:@guardian/cdk
to repository; update CI & deployment wiring accordingly [this PR]@guardian/cdk
(Add cdk-defined version of API infrastructure #65)@guardian/cdk
(but continue routing requests to old infrastructure) (Move domain name configuration from CFN to cdk #66)In this PR, we 'wrap' the existing CloudFormation with
@guardian/cdk
, following the process described here.Note that all changes in 6179bb0 are auto-generated by
@guardian/cdk
project creation tooling; I would not spend much time reviewing this in detail!There are, however, a couple of changes that require a little more explanation:
AWS::Serverless-2016-10-31
to 'standard' CloudFormation (1389750).CODE
and a different file forPROD
), instead of a single template for both stages (ad96d92).@guardian/cdk
has chosen to deal with multiple stages. For motivation see: https://github.com/guardian/cdk/blob/main/docs/architecture-decision-records/006-stage-awareness.md. As it stands the contents of these templates are identical, but that will change in the second PR of this migration process.How to test
I've deployed this to
CODE
and used a debug version of the app to confirm that saving articles/viewing saved articles still works as expected. (I checked the AWS Lambda logs and DynamoDB to confirm that server side code was being exercised as expected).How can we measure success?
We have started the migration process to
@guardian/cdk
.Have we considered potential risks?
This PR should be pretty low risk; we are changing CI and CD wiring, but the actual infrastructure serving requests will not change substantially (i.e. we just change the metadata by adding some new tags).