Move domain name configuration from CFN to cdk #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2022
jacobwinch
commented
May 24, 2022
jacobwinch
commented
May 24, 2022
jacobwinch
commented
May 24, 2022
akash1810
reviewed
May 24, 2022
2 tasks
waisingyiu
approved these changes
May 30, 2022
jacobwinch
force-pushed
the
jw-cdk-migration-part-2
branch
from
8a10497 to
6e0aa90
Compare
jacobwinch
force-pushed
the
jw-cdk-migration-part-3
branch
from
fb069db to
9d93348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B. this PR depends on #64 and #65.
What does this change?
We are migrating the
mobile-save-for-laterservice from CloudFormation to@guardian/cdk. The migration will involve 5 PRs:@guardian/cdkto repository; update CI & deployment wiring accordingly (Add @guardian/cdk to repository and deploy stage-specific templates #64)@guardian/cdk(Add cdk-defined version of API infrastructure #65)@guardian/cdk(but continue routing requests to old infrastructure) [this PR]How to test
I've deployed this to CODE and used a debug version of the app to confirm that saving articles/viewing saved articles still works as expected. (I checked the AWS Lambda logs and DynamoDB to confirm that server side code was being exercised as expected).
How can we measure success?
We are a step closer to defining all infrastructure using
@guardian/cdk!Have we considered potential risks?
Yes, the risk is still low at this stage. Although we have moved some resources from CloudFormation into
@guardian/cdk, this PR doesn't actually make any DNS changes.