-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cdk-defined version of API infrastructure #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
changed the title
Add cdk-defined version of API infrastructre
Add cdk-defined version of API infrastructure
May 24, 2022
This was referenced May 24, 2022
jacobwinch
commented
May 24, 2022
jacobwinch
commented
May 24, 2022
jacobwinch
commented
May 24, 2022
jacobwinch
commented
May 24, 2022
jacobwinch
commented
May 24, 2022
jacobwinch
commented
May 24, 2022
jacobwinch
commented
May 24, 2022
akash1810
reviewed
May 24, 2022
jacobwinch
commented
May 24, 2022
2 tasks
waisingyiu
reviewed
May 30, 2022
waisingyiu
reviewed
May 30, 2022
waisingyiu
approved these changes
Jun 6, 2022
jacobwinch
force-pushed
the
jw-cdk-migration-part-1
branch
from
June 8, 2022 13:25
ddbb924
to
d41367a
Compare
jacobwinch
force-pushed
the
jw-cdk-migration-part-2
branch
from
June 8, 2022 13:41
8a10497
to
6e0aa90
Compare
This was referenced Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B. this PR depends on #64.
What does this change?
We are migrating the
mobile-save-for-later
service from CloudFormation to@guardian/cdk
. The migration will involve 5 PRs:@guardian/cdk
to repository; update CI & deployment wiring accordingly (Add @guardian/cdk to repository and deploy stage-specific templates #64)@guardian/cdk
[this PR]@guardian/cdk
(but continue routing requests to old infrastructure) (Move domain name configuration from CFN to cdk #66)How to test
I've deployed this to
CODE
to confirm that the deployment works as expected.How can we measure success?
We are a step closer to defining all infrastructure using
@guardian/cdk
!Have we considered potential risks?
Yes, the risk is very low at this stage. Although we have provisioned a new API/Lambdas, the old API/Lambdas still serve all of the traffic.