Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cdk-defined version of API infrastructure #65

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

jacobwinch
Copy link
Contributor

@jacobwinch jacobwinch commented May 24, 2022

N.B. this PR depends on #64.

What does this change?

We are migrating the mobile-save-for-later service from CloudFormation to @guardian/cdk. The migration will involve 5 PRs:

  1. Add @guardian/cdk to repository; update CI & deployment wiring accordingly (Add @guardian/cdk to repository and deploy stage-specific templates #64)
  2. Provision a new version of the infrastructure using @guardian/cdk [this PR]
  3. Move DNS configuration from CloudFormation into @guardian/cdk (but continue routing requests to old infrastructure) (Move domain name configuration from CFN to cdk #66)
  4. Update DNS configuration (start routing requests to new infrastructure) (Route all traffic to the cdk-defined infrastructure #67)
  5. Remove old infrastructure (Remove superfluous resources - these have been replaced by GuCDK versions #73)

How to test

I've deployed this to CODE to confirm that the deployment works as expected.

How can we measure success?

We are a step closer to defining all infrastructure using @guardian/cdk!

Have we considered potential risks?

Yes, the risk is very low at this stage. Although we have provisioned a new API/Lambdas, the old API/Lambdas still serve all of the traffic.

@jacobwinch jacobwinch changed the title Add cdk-defined version of API infrastructre Add cdk-defined version of API infrastructure May 24, 2022
cdk/package.json Outdated Show resolved Hide resolved
cdk/lib/mobile-save-for-later.ts Show resolved Hide resolved
cdk/lib/mobile-save-for-later.ts Show resolved Hide resolved
cdk/lib/mobile-save-for-later.ts Outdated Show resolved Hide resolved
cdk/lib/mobile-save-for-later.ts Outdated Show resolved Hide resolved
@jacobwinch jacobwinch force-pushed the jw-cdk-migration-part-1 branch from ddbb924 to d41367a Compare June 8, 2022 13:25
Base automatically changed from jw-cdk-migration-part-1 to master June 8, 2022 13:39
@jacobwinch jacobwinch force-pushed the jw-cdk-migration-part-2 branch from 8a10497 to 6e0aa90 Compare June 8, 2022 13:41
@jacobwinch jacobwinch marked this pull request as ready for review June 8, 2022 13:52
@jacobwinch jacobwinch merged commit 867e2e3 into master Jun 8, 2022
@jacobwinch jacobwinch deleted the jw-cdk-migration-part-2 branch June 8, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants