Publish status messages (read in Fronts tool) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
force-pushed
the
jsh/publish-status-messages
branch
from
a52cb9f
to
e48f887
Compare
jonathonherbert
force-pushed
the
jsh/publish-status-messages
branch
2 times, most recently
from
31fc6ee
to
f39b5c1
Compare
jonathonherbert
force-pushed
the
jsh/publish-status-messages
branch
from
f39b5c1
to
d30cc92
Compare
|
Currently failing to post messages to the SNS topic with |
jonathonherbert
force-pushed
the
jsh/publish-status-messages
branch
from
dc89d40
to
055bd77
Compare
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
jonathonherbert
force-pushed
the
jsh/publish-status-messages
branch
from
9b7716f
to
16753c4
Compare
emdash-ie
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Had some trouble deploying to CODE, but other than that this looks good to me! One comment about the indentation in a file, but that’s pretty unimportant – can definitely merge without addressing that.
The trouble deploying to CODE is more troubling: it looks like it’s trying to recreate a dead-letter queue for some reason?
jonathonherbert
force-pushed
the
jsh/publish-status-messages
branch
from
d927337
to
58e63fb
Compare
|
Deployed now – recommend testing with an empty issue for now, e.g. https://fronts.code.dev-gutools.co.uk/v2/issues/10415d60-87c0-4f26-a6fa-9bcc5aa246aa, as Chef validation is waiting on guardian/facia-tool#1612. (I've tested, it looks good!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Publishes status messages on curation deploy succeed or failure to an SNS topic, which is read in the Fronts tool.
How to test
Tested in CODE: