Update Feast model to draw data from new card meta

[jonathonherbert]

What's changed?

Updates our Feast model to draw data from the new card meta introduced in #1589, #1607, and #1609.

How to test

• The automated tests should pass ✅
• In Fronts CODE, create an issue with lots of different card types, and hit publish.
• Ensure there are no error logs (example logs.)
• Check what was published by visiting the relevant content endpoint, e.g recipes.code.dev-guardianapis.com/feast-northern-hemisphere/all-recipes/2024-08-01/curation.json

For example, for the input:

We get the output:

Expand to see JSON

[
    {
        "id": "7018406a-e9a0-442b-80d8-f22cba53ceee",
        "title": "Dish of the day",
        "body": "",
        "items": [
            {
                "backgroundHex": "#BB3B80",
                "id": "profile/yotamottolenghi",
                "bio": "Yotam Ottolenghi is  chef-patron of the Ottolenghi delis and the Nopi and Rovi restaurants. He has  published 10 bestselling cookbooks",
                "foregroundHex": "#F9F9F5"
            },
            {
                "darkPalette": {
                    "backgroundHex": "#363632",
                    "foregroundHex": "#FCF1F0"
                },
                "image": "https://uploads.guim.co.uk/2024/03/21/Baking.png",
                "title": "Sweet treats",
                "lightPalette": {
                    "backgroundHex": "#F9F9F5",
                    "foregroundHex": "#DB2712"
                },
                "recipes": [
                    "c2c9118b7e7b4a4aae48f31d4704dbd1",
                    "ae779e4975904ba6a601449e513d88f7"
                ]
            },
            {
                "recipe": {
                    "id": "c2c9118b7e7b4a4aae48f31d4704dbd1"
                }
            },
            {
                "recipe": {
                    "id": "ae779e4975904ba6a601449e513d88f7"
                }
            }
        ]
    },
    {
        "id": "a9949d60-2b76-4f71-88ba-4e7ff9636c71",
        "title": "Collection 2",
        "body": "",
        "items": []
    },
    {
        "id": "914bad50-1493-41c8-b3da-6a1bde94ab42",
        "title": "Collection 3",
        "body": "",
        "items": []
    },
    {
        "id": "ec085650-b225-478a-914f-4cb3efb22ce4",
        "title": "Collection 4",
        "body": "",
        "items": []
    },
    {
        "id": "bdd83158-62c7-4a1a-a4d6-75786d4a397d",
        "title": "Collection 5",
        "body": "",
        "items": []
    },
    {
        "id": "8ba7b176-3677-4559-9479-79be518276bf",
        "title": "Collection 6",
        "body": "",
        "items": []
    },
    {
        "id": "c9ae61e9-29fd-44ea-ae85-637d9be987d6",
        "title": "Collection 7",
        "body": "",
        "items": []
    },
    {
        "id": "368b0a3f-e7d6-4f0e-963b-c216e78f8370",
        "title": "Collection 8",
        "body": "",
        "items": []
    },
    {
        "id": "008aef4d-73a3-4ed4-9ac0-563df9388398",
        "title": "Collection 9",
        "body": "",
        "items": []
    }
]

Checklist

General

• 🤖 Relevant tests added
• ✅ CI checks / tests run locally
• 🔍 Checked on CODE

Client

• 🚫 No obvious console errors on the client (i.e. React dev mode errors)
• 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
• 📷 Screenshots / GIFs of relevant UI changes included

[github-actions]

Deploy build 8254 of cms-fronts::facia-tool to CODE

All deployment options

• Deploy build 8254 of cms-fronts::facia-tool to CODE
• Deploy parts of build 8254 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[emdash-ie]

Looks good!

Enabling some unused warnings from the scala compiler shows a number of unused imports and parameters – it’d be worth us cleaning those up in a subsequent PR.

[emdash-ie]

The id and addedOn pattern variables here are unused (confirmed by adding -Wunused:patvars to scalacOptions), as is the addedOn variable on line 35. Just wanted to confirm that’s intended! (I’d be tempted to prefix their names with an underscore to indicate they’re deliberately not used.)

[jonathonherbert]

Intentional as there's no place in the downstream Feast model for these values, AFAIK (ids are for the Fronts relational model, and Feast doesn't care when these items were initially curated), so I've cleaned up as you've suggested in ca5758a.

[emdash-ie]

I should note I haven’t tested this on CODE yet, and from the bullet point in the PR description it sounds like you haven’t either. We should do that before merge: I’ll try to get to it tomorrow.

[emdash-ie]

Ok, deployed to CODE, created an issue, published it, saw no errors in the logs. All good!

One behaviour surprised me: I can drag recipes into a collection from the clipboard, but not from the search result pane on the left. I assume that’s already known about and we have a trello card to fix it, but I wanted to mention it just in case.

[jonathonherbert]

Apologies, should have updated the PR description – this was tested in CODE, and thank you for testing, too!

Spot on re: compiler warnings. It looks like you've raised a draft PR for that: thank you! Happy to take that forward, or would you like to continue?

> One behaviour surprised me: I can drag recipes into a collection from the clipboard, but not from the search result pane on the left. I assume that’s already known about and we have a trello card to fix it, but I wanted to mention it just in case.

This is a bug, thank you for spotting! This PR has a clear backend focus, so we'll card and fix in another PR.

[prout-bot]

Seen on PROD (merged by @jonathonherbert 6 minutes and 23 seconds ago) Please check your changes!

[emdash-ie]

Spot on re: compiler warnings. It looks like you've raised a draft PR for that: thank you! Happy to take that forward, or would you like to continue?

No strong feelings! If you want to, go for it – I’ll get to it when I have some time.